Feature/translation by TQuynh109 · Pull Request #350 · 666ghj/MiroFish

TQuynh109 · 2026-03-26T05:21:33Z

Translation

Copilot

Pull request overview

This PR updates user-facing UI text, inline comments, and log/error strings across the frontend and backend to support translation/localization.

Changes:

Translated/rewrote labels and status messages in Vue components for the graph build flow and graph visualization.
Updated frontend API module JSDoc/comments and backend docstrings/log/error messages to translated text.
Adjusted project metadata copy (HTML title/description) and various operational docs/comments (Docker, scripts).

Reviewed changes

Copilot reviewed 45 out of 60 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
frontend/src/components/Step1GraphBuild.vue	Translates step labels/status text for the graph build wizard and simulation entry action.
frontend/src/components/GraphPanel.vue	Translates tooltips, hints, and numerous inline comments/text in the graph visualization panel.
frontend/src/api/simulation.js	Translates API JSDoc comments for simulation endpoints.
frontend/src/api/report.js	Translates API JSDoc comments for report endpoints.
frontend/src/api/index.js	Translates axios setup/interceptor comments and keeps retry helper documentation aligned.
frontend/src/api/graph.js	Translates JSDoc comments for graph/ontology API helpers.
frontend/src/App.vue	Translates global comment labels for styles/router reference.
frontend/index.html	Translates page title/description meta content to English.
docker-compose.yml	Translates inline comment for image mirror usage.
backend/scripts/test_profile_format.py	Translates module/docstrings and console output text used by the script.
backend/scripts/run_reddit_simulation.py	Translates extensive script documentation/log output and inline comments.
backend/scripts/action_logger.py	Translates docstrings/comments describing log formats and logger behavior.
backend/run.py	Translates console messages/comments in backend entrypoint.
backend/requirements.txt	Translates section header comments in dependency list.
backend/pyproject.toml	Translates project description and dependency section comments.
backend/app/utils/zep_paging.py	Translates module/function docstrings for Zep paging utility.
backend/app/utils/retry.py	Translates docstrings and log messages of retry utilities.
backend/app/utils/logger.py	Translates logger module docstrings/comments and preserves behavior.
backend/app/utils/llm_client.py	Translates docstrings and error messages for LLM client wrapper.
backend/app/utils/file_parser.py	Translates docstrings/messages for file parsing and text extraction utilities.
backend/app/utils/init.py	Translates module docstring.
backend/app/services/zep_graph_memory_updater.py	Translates service docstrings/comments and user-facing error strings.
backend/app/services/zep_entity_reader.py	Translates docstrings, log/error messages for entity reader/filter service.
backend/app/services/text_processor.py	Translates docstrings/comments for text processing service.
backend/app/services/simulation_manager.py	Translates docstrings/status comments and progress/error strings in simulation preparation flow.
backend/app/services/simulation_ipc.py	Translates IPC module docstrings/comments/messages for command/response flow.
backend/app/services/ontology_generator.py	Translates system prompt and docstrings for ontology generation.
backend/app/services/graph_builder.py	Translates docstrings/progress messages for graph building service.
backend/app/models/task.py	Translates Task/TaskManager docstrings/comments and default completion/failure messages.
backend/app/models/project.py	Translates Project/ProjectManager docstrings/comments and some inline comments.
backend/app/models/init.py	Translates module docstring.
backend/app/config.py	Translates config docstrings/comments and validation error strings.
backend/app/api/graph.py	Translates API route docs/log/error strings for graph/project/task endpoints.
backend/app/api/init.py	Translates module docstring.
backend/app/init.py	Translates app factory docstrings/comments and startup/request logging strings.
Dockerfile	Translates build/run comments for container image.

Files not reviewed (1)

frontend/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-26T05:22:58Z

backend/app/models/task.py

    def complete_task(self, task_id: str, result: Dict):
-        """标记任务完成"""
+        """Hành động đánh dấu tác vụ đã kết thúc Thành Công và gán 100% cho progress"""
        self.update_task(
            task_id,
            status=TaskStatus.COMPLETED,
            progress=100,
-            message="任务完成",
+            message="The task has been completed!",
            result=result
        )

    def fail_task(self, task_id: str, error: str):
-        """标记任务失败"""
+        """Hành động đánh dấu tác vụ đã Thất Bại do lỗi"""
        self.update_task(
            task_id,
            status=TaskStatus.FAILED,
-            message="任务失败",
+            message="The task has an error!?",
            error=error
        )


The translated default task messages are likely user-facing and should remain professional, consistent, and unambiguous. "The task has an error!?" reads uncertain and is not a good stable UI string; consider using consistent neutral phrasing (e.g., "Task completed" / "Task failed"), and (optionally) keeping human-readable text out of the TaskManager defaults in favor of caller-provided messages for localization.

Copilot · 2026-03-26T05:22:58Z

backend/app/services/simulation_manager.py

                progress_callback(
                    "reading", 100, 
-                    f"完成，共 {filtered.filtered_count} 个实体",
+                    f"Extraction complete, filtered entity count: {filtered.filtered_count} empty entities",


This progress message is internally inconsistent: filtered.filtered_count represents the number of matched entities, but the text says “empty entities”. This will confuse users and makes debugging harder. Recommend changing the wording to reflect the actual count (e.g., “Extraction complete: {n} entities”) and removing “empty”.

Suggested change

f"Extraction complete, filtered entity count: {filtered.filtered_count} empty entities",

f"Extraction complete: {filtered.filtered_count} entities extracted",

Copilot · 2026-03-26T05:22:58Z

backend/app/api/graph.py

        task_manager = TaskManager()
-        task_id = task_manager.create_task(f"构建图谱: {graph_name}")
-        logger.info(f"创建图谱构建任务: task_id={task_id}, project_id={project_id}")
+        task_id = task_manager.create_task(f"Build graph: {graph_name}")


TaskManager.create_task()’s first argument is task_type, which is commonly used for grouping/filtering tasks; passing a human-readable, variable string like "Build graph: {graph_name}" makes task types effectively unbounded. Prefer using a stable type identifier (e.g., "graph_build") and store graph_name in metadata or in the task message field.

Suggested change

task_id = task_manager.create_task(f"Build graph: {graph_name}")

task_id = task_manager.create_task("graph_build")

Copilot · 2026-03-26T05:22:59Z

backend/app/utils/file_parser.py

+    Áp dụng chiến lược fallback nhiều tầng:
+    1. Thử giải mã bằng UTF-8 trước
+    2. Dùng charset_normalizer để phát hiện mã hóa
+    3. Fallback sang chardet de phat hien ma hoa


The Vietnamese docstring line contains an unaccented phrase ("de phat hien ma hoa"), likely an accidental typo/inconsistent translation. Consider correcting it for readability and consistency.

Suggested change

3. Fallback sang chardet de phat hien ma hoa

3. Fallback sang chardet để phát hiện mã hóa

Copilot · 2026-03-26T05:22:59Z

frontend/src/components/Step1GraphBuild.vue

          </div>
          <div class="step-status">
-            <span v-if="currentPhase >= 2" class="badge accent">进行中</span>
+            <span v-if="currentPhase >= 2" class="badge accent">In Progress</span>


The step title “Build Complete” conflicts with the status badge text “In Progress” for the same phase, which can mislead users. Consider aligning the badge wording with the step semantics (e.g., “Ready”, “Completed”, or a phase-appropriate state) so the UI doesn’t present contradictory status.

Suggested change

<span v-if="currentPhase >= 2" class="badge accent">In Progress</span>

<span v-if="currentPhase >= 2" class="badge accent">Ready</span>

666ghj · 2026-04-02T08:00:51Z

The project already has i18n support in place — please refer to [PR #428] for reference.

ththu0205 and others added 4 commits March 25, 2026 03:58

translation comment code - backend - models folder

950e8a8

translate backend folder

1b986f7

translate

e28c529

translate frontend folder

e09cfe9

Copilot AI review requested due to automatic review settings March 26, 2026 05:21

dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels Mar 26, 2026

Copilot AI reviewed Mar 26, 2026

View reviewed changes

KieuVui deleted the feature/translation branch March 26, 2026 05:35

666ghj closed this Apr 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/translation#350

Feature/translation#350
TQuynh109 wants to merge 4 commits into666ghj:mainfrom
TQuynh109:feature/translation

TQuynh109 commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 26, 2026

Uh oh!

Copilot AI Mar 26, 2026

Uh oh!

Copilot AI Mar 26, 2026

Uh oh!

Copilot AI Mar 26, 2026

Uh oh!

Copilot AI Mar 26, 2026

Uh oh!

666ghj commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	f"Extraction complete, filtered entity count: {filtered.filtered_count} empty entities",
	f"Extraction complete: {filtered.filtered_count} entities extracted",

	task_id = task_manager.create_task(f"Build graph: {graph_name}")
	task_id = task_manager.create_task("graph_build")

	3. Fallback sang chardet de phat hien ma hoa
	3. Fallback sang chardet để phát hiện mã hóa

	<span v-if="currentPhase >= 2" class="badge accent">In Progress</span>
	<span v-if="currentPhase >= 2" class="badge accent">Ready</span>

Conversation

TQuynh109 commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

666ghj commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants